Skip to content

Remove obsolete Home issue-reporting sheet and models (UI-SETTINGS-A-4) - #2613

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-ui-settings-a-4
Nov 13, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-ui-settings-a-4

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Removes the old Home “Report an issue” sheet, its two private selector views and internal models for UI-SETTINGS-A-4. The presenter was replaced in #2274. This also removes the unused feedback target still constructed and carried by meeting previews, its orphan FNV helper and the helper’s four legacy assertions. Two file-inventory docs now match the remaining sources.

The live Report issue menu still opens the current Feedback composer. Sidebar/About Feedback, Email Support, Send Diagnostics, current diagnostics opt-in defaults, explicit review/send and preview identity/rename/markdown updates remain unchanged. The separately covered OBSERVABILITY-6 builder path is excluded.

DEAD-CODE-1 describes the same old chain. It is a duplicate report finding, not a second implementation; a separate docs-only disposition can reference this cleanup. The report’s “partly fixed” preview-field removal in broad draft #2336 is not landed on the fetched main base and is included here. No duplicate code fix or independent alias coverage is claimed.

Validation at eb7c3f6633169fc41e1a2c62b85d4c9f627618f5 against fetched origin/main (8a38235):

  • Independent full actual seven-file diff review by the coordinator: GREEN; 35 explicit current/base bindings verified, including the deleted file’s base blob. All 28 protected inputs remain base-identical. Repository references support removal of the old chain while retained production callsites still open the current composer.
  • One guarded canonical bash check.sh: exit 1, raw deterministic FAIL. Twenty-one checks passed, including real app/keyboard build and signing, concurrency census, source pins, test shape and module/policy checks. Full fast-suite invocation was refused before execution by the common guard (exit 3); the separate preflight orchestration entry is SKIPPED metadata. Exact-head raw agent-proof.json was archived before the verifier. No check retry occurred.
  • Standalone agent preflight: exit 0. Verifier: exit 0; its own --no-open build passed, then UI and speed SKIP because Transcripted was already running. Nothing was quit; launch smoke was disabled. SKIP provides no rendered UI or timing proof.
  • One outer full QA bench invocation: guard exit 3 before execution. No new tests/component runs or feedback, diagnostic, permission, capture, preferences or native UI runtime. Retained current-composer/privacy tests were source-reviewed, not executed.
  • Hosted CI: UNKNOWN at local closeout. Manual UI proof remains UNKNOWN. No merge or release.

App verification

Base: origin/main · head: eb7c3f663

Check Result Detail
ui SKIP Transcripted is already running; quit it and rerun with --only ui
speed SKIP Transcripted is already running; nothing was quit

@r3dbars r3dbars added the needs owner review Owner must review before merge label Nov 11, 2026
@r3dbars
r3dbars merged commit 70bb2b8 into main Nov 13, 2026
16 of 22 checks passed
@r3dbars
r3dbars deleted the codex/review-ui-settings-a-4 branch November 13, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs owner review Owner must review before merge risk:high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant