Repository navigation
Remove obsolete Home issue-reporting sheet and models (UI-SETTINGS-A-4) - #2613
Merged
Merged
Conversation
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the old Home “Report an issue” sheet, its two private selector views and internal models for UI-SETTINGS-A-4. The presenter was replaced in #2274. This also removes the unused feedback target still constructed and carried by meeting previews, its orphan FNV helper and the helper’s four legacy assertions. Two file-inventory docs now match the remaining sources.
The live Report issue menu still opens the current Feedback composer. Sidebar/About Feedback, Email Support, Send Diagnostics, current diagnostics opt-in defaults, explicit review/send and preview identity/rename/markdown updates remain unchanged. The separately covered OBSERVABILITY-6 builder path is excluded.
DEAD-CODE-1 describes the same old chain. It is a duplicate report finding, not a second implementation; a separate docs-only disposition can reference this cleanup. The report’s “partly fixed” preview-field removal in broad draft #2336 is not landed on the fetched main base and is included here. No duplicate code fix or independent alias coverage is claimed.
Validation at
eb7c3f6633169fc41e1a2c62b85d4c9f627618f5against fetchedorigin/main(8a38235):bash check.sh: exit 1, raw deterministic FAIL. Twenty-one checks passed, including real app/keyboard build and signing, concurrency census, source pins, test shape and module/policy checks. Full fast-suite invocation was refused before execution by the common guard (exit 3); the separate preflight orchestration entry is SKIPPED metadata. Exact-head rawagent-proof.jsonwas archived before the verifier. No check retry occurred.--no-openbuild passed, then UI and speed SKIP because Transcripted was already running. Nothing was quit; launch smoke was disabled. SKIP provides no rendered UI or timing proof.App verification
Base:
origin/main· head:eb7c3f663